Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More L1T bug fixes [11.1.x] #30610

Merged
merged 4 commits into from
Jul 9, 2020
Merged

More L1T bug fixes [11.1.x] #30610

merged 4 commits into from
Jul 9, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jul 9, 2020

PR description:

Fix several bugs found by @tommasoboccali.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport #30606 .

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 9, 2020

@cmsbuild, please test

@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone Jul 9, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020 •
edited
Loading

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020 •
edited
Loading

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_11_1_X.

It involves the following packages:

DataFormats/L1Trigger
L1Trigger/Configuration
L1Trigger/L1CaloTrigger

@cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @rovere, @kreczko, @thomreis this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 9, 2020

backport #30606

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 9, 2020

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 9, 2020

urgent

@cmsbuild cmsbuild added the urgent label Jul 9, 2020
@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit c73599c into cms-sw:CMSSW_11_1_X Jul 9, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

+1
Tested at: 5816a46
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75833e/7816/summary.html
CMSSW: CMSSW_11_1_X_2020-07-08-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75833e/7816/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780741
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Jul 9, 2020

+upgrade

@fwyzard fwyzard deleted the backport_30606 branch July 10, 2020 11:36
@cmsbuild cmsbuild mentioned this pull request Jul 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport bug-fix comparison-available l1-pending orp-approved pending-signatures tests-approved upgrade-approved urgent
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.
4 participants
@fwyzard @cmsbuild @silviodonato @kpedro88